Migration Guide > Functional Components の翻訳 #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vuejs-v3-ja-doc-preview ready! Built with commit fc80c14 https://deploy-preview-142--vuejs-v3-ja-doc-preview.netlify.app |
potato4d
approved these changes
Oct 26, 2020
|
|
||
| Using the `<dynamic-heading>` component, which is responsible for rendering out the appropriate heading (i.e., `h1`, `h2`, `h3`, etc.), this could have been written as a single-file component in 2.x as: | ||
| 適切な見出し（つまり `h1`, `h2`, `h3` など）のレンダリングを担当する `<dynamic-heading>` コンポーネントは、2.x では単一ファイルコンポーネントとして次のように記述できました: |
There was a problem hiding this comment.
コメントにあった部分ここですよね。
<dynamic-heading> コンポーネントを使用すると〜から初めて先に Using the <dynamic-heading> component を消化し、which is ~ を読点のあとに持っていくのが読みやすいかもしれないですね
There was a problem hiding this comment.
L92 が使うと〜なので、同じように使うと〜で統一するほうが良さそうだろうか
There was a problem hiding this comment.
@potato4d レビューありがとうございます！
提案いただいた内容ですと、以下のように直すイメージでよろしいでしょうか？
<dynamic-heading>コンポーネントを使うと、適切な見出し（つまりh1,h2,h3など）のレンダリングを担当するコンポーネントは 2.x では単一ファイルコンポーネントとして次のように記述できました:
There was a problem hiding this comment.
@potato4d 修正しましたのでご確認よろしくお願いします:pray:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #116
https://v3.vuejs.org/guide/migration/functional-components.html の翻訳です。
なるべく「一語一句翻訳」のガイドラインに沿って翻訳しております。
32行目について、冒頭の
Usingのうまい訳が思いつかず、軽い意訳になっております。118行目のリンクはページの翻訳が終わってからタイトルを合わせる必要がありそうです。（取り急ぎ、ガイドのタイトルに合わせてあります）
ご確認よろしくお願いします。